build: add ci workflow to verify c89 build and tests#119
Closed
build: add ci workflow to verify c89 build and tests#119
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a GitHub Actions workflow to enforce C89 compatibility by building and testing argtable3 in both Debug and Release modes.
- Installs CMake, GCC, and Make on ubuntu-latest runners
- Configures, builds (with -Wall -Wextra -pedantic) and runs tests in strict C89 for Debug and Release
- Triggers on workflow_dispatch, pushes to
master, and pull requests
Comments suppressed due to low confidence (1)
.github/workflows/c89.yml:7
- [nitpick] Restrict
pull_requestto themasterbranch (e.g.,pull_request: branches: [ master ]) to mirror thepushtrigger and avoid unintended runs on feature branches.
pull_request:
tomghuang
force-pushed
the
feature-add-c89-build-workflow
branch
2 times, most recently
from
c7d3f22 to
3cbf52d
Compare
This patch introduces a workflow that ensures argtable3 can be built with GCC in strict C89 mode. The workflow builds both Debug and Release configurations and runs all unit tests for each. The workflow will fail if any build or test fails, guaranteeing C89 compatibility and test coverage on every change.
tomghuang
force-pushed
the
feature-add-c89-build-workflow
branch
from
3cbf52d to
b243cff
Compare
Contributor
Author
|
This pull request is not necessary because we already add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces a workflow that ensures argtable3 can be built with GCC in strict C89 mode. The workflow builds both Debug and Release configurations and runs all unit tests for each. The workflow will fail if any build or test fails, guaranteeing C89 compatibility and test coverage on every change.